On 06.09.2020 14:44, Krzysztof Kozlowski wrote: >>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>> index a1e93fb7f694..89b160280469 100644 >>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>> @@ -214,6 +214,7 @@ >>> compatible = "samsung,exynos3250-cmu"; >>> reg = <0x10030000 0x20000>; >>> #clock-cells = <1>; >>> + clocks = <&cmu CLK_FIN_PLL>; >> This is not a correct input clock for this CMU. Please assign it to >> xusbxti, xxti or xtcxo in the respective board dts, as this is a board >> property. > Makes sense, although all this is kind of a hack as neither the bindings > nor the driver take the input clock. I think we should update the bindings so possible input clocks to the CMU are documented for all SoCs. This is actually a bug in the clock controller DT bindings that the input clocks are missing. Then the driver would handle both the old and the updated bindings but the "clocks" property would be documented as mandatory. I will try to have a look at this.
