Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/3/2020 6:04 PM, André Przywara wrote:
On 02/09/2020 00:04, Florian Fainelli wrote:

Hi Florian,

sorry, the mail got swamped in my inbox...

On 8/28/2020 10:12 AM, Florian Fainelli wrote:
On 8/28/20 7:20 AM, Andre Przywara wrote:
The DT binding for SP804 requires to have an "arm,primecell" compatible
string.
Add this string so that the Linux primecell bus driver picks the device
up and activates the clock.

Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT")
Tested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
This looks fine, however there is a ccbtimer1 instance that you missed,
can you resubmit with it included?

With that:

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Andre are you going to resubmit a patch with the second instance
(ccbtimer1) fixed as well, or should I take care of that while applying
the patch? Either way is fine, just let me know.
So I was waiting for more comments, but there was nothing so far that
justifies a new version. So would you mind fixing this while applying? I
must have indeed missed this instance while diffing before and after.
Applied and fixed up the ccbtimer1 node, thanks.
--
Florian



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux