On 18/08/2020 10.00, Reddy, MallikarjunaX wrote: > Hi Rob, > Thanks for your valuable comments. Please see my comments inline.. > > On 8/15/2020 4:32 AM, Rob Herring wrote: >> On Fri, Aug 14, 2020 at 01:26:09PM +0800, Amireddy Mallikarjuna reddy >> wrote: >>> Add DT bindings YAML schema for DMA controller driver >>> of Lightning Mountain(LGM) SoC. >>> >>> Signed-off-by: Amireddy Mallikarjuna reddy >>> <mallikarjunax.reddy@xxxxxxxxxxxxxxx> >>> --- >>> v1: >>> - Initial version. >>> >>> v2: >>> - Fix bot errors. >>> >>> v3: >>> - No change. >>> >>> v4: >>> - Address Thomas langer comments >>> - use node name pattern as dma-controller as in common binding. >>> - Remove "_" (underscore) in instance name. >>> - Remove "port-" and "chan-" in attribute name for both >>> 'dma-ports' & 'dma-channels' child nodes. >>> >>> v5: >>> - Moved some of the attributes in 'dma-ports' & 'dma-channels' child >>> nodes to dma client/consumer side as cells in 'dmas' properties. >>> --- >>> .../devicetree/bindings/dma/intel,ldma.yaml | 319 >>> +++++++++++++++++++++ >>> 1 file changed, 319 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/dma/intel,ldma.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/dma/intel,ldma.yaml >>> b/Documentation/devicetree/bindings/dma/intel,ldma.yaml >>> new file mode 100644 >>> index 000000000000..9beaf191a6de >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/dma/intel,ldma.yaml >>> @@ -0,0 +1,319 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/dma/intel,ldma.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Lightning Mountain centralized low speed DMA and high speed >>> DMA controllers. >>> + >>> +maintainers: >>> + - chuanhua.lei@xxxxxxxxx >>> + - mallikarjunax.reddy@xxxxxxxxx >>> + >>> +allOf: >>> + - $ref: "dma-controller.yaml#" >>> + >>> +properties: >>> + $nodename: >>> + pattern: "^dma-controller(@.*)?$" >>> + >>> + "#dma-cells": >>> + const: 1 >> Example says 3. > OK, i will fix it. It would help if you would add description of what is the meaning of the individual cell. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
