Hello Rob, Thanks for the review. On Thu, 2020-09-03 at 10:13 -0600, Rob Herring wrote: > On Wed, 02 Sep 2020 20:01:21 +0800, Dongchun Zhu wrote: > > Add YAML device tree binding for OV02A10 CMOS image sensor, > > and the relevant MAINTAINERS entries. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > --- > > .../bindings/media/i2c/ovti,ov02a10.yaml | 161 +++++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 168 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dts:28.45-46 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1366: dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1355723 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > So much sorry for the mistake I've made. I forgot to include the header file 'dt-bindings/gpio/gpio.h'. This would be fixed in next release :-)