Hi again... On 02/09/20 08:46, Luca Ceresoli wrote: > Hi Sowjanya, > > On 02/09/20 04:04, Sowjanya Komatineni wrote: >> This patch adds IMX274 optional external clock input and voltage >> supplies to device tree bindings. >> >> Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> >> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx> >> --- >> .../devicetree/bindings/media/i2c/sony,imx274.yaml | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml >> index 7ae47a6..57e7176 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml >> @@ -25,6 +25,27 @@ properties: >> reset-gpios: >> maxItems: 1 >> >> + clocks: >> + maxItems: 1 >> + description: Reference to the sensor input clock >> + >> + clock-names: >> + maxItems: 1 >> + items: >> + - const: inck > > I think this can be simpler: > > clock-names: > maxItems: 1 > items: > - const: inck Which is equal to the original... copy-paste-and-forgot. Here's the simplified form, for real: clocks: maxItems: 1 clock-names: const: inck As in: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml?h=v5.9-rc3#n90 -- Luca