On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker <guillaume.tucker@xxxxxxxxxxxxx> wrote: > > Hi Krzysztof, Russell, > > On 10/08/2020 13:22, Guillaume Tucker wrote: > > The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable > > sequence. There is no need to set it in the default register value, > > this was done before support for it was implemented in the code. It > > is not set in the hardware initial value either. > > > > Clean this up by removing this flag from the default l2c_aux_val, and > > add it to the l2c_aux_mask to print an alert message if it was already > > set before the kernel initialisation. > > > > Signed-off-by: Guillaume Tucker <guillaume.tucker@xxxxxxxxxxxxx> > > --- > > > > Notes: > > v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN > > > > arch/arm/mach-exynos/exynos.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > I believe this v2 series has addressed all previous comments and > you were waiting for the 5.9 merge window to end. The patches > all still apply cleanly on v5.9-rc3. Do you want me to resend > the series anyway or is there anything else needed at this point? > > Maybe one thing that wasn't completely clear in v1 was whether > patch 2/4 was the right approach. I've explained the reason > behind it but didn't get a final reply from Russell[1]. I am sorry, my bad. I already applied this one and 3/4 (dts). Apparently I forgot to reply with confirmation and Patchwork did not notify you for some reason. Patch 2/4 does not look like one for me so I would need ack from Russell to take. Did you submit it to the ARM patches queue? Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch. Best regards, Krzysztof
