> + priv->refclk = devm_clk_get_optional(dev, NULL); > + if (IS_ERR(priv->refclk)) { > + if (PTR_ERR(priv->refclk) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + > + /* Clocks are optional all errors should be ignored here */ > + return 0; Since you are calling devm_clk_get_optional() isn't an error a real error, not that the clock is missing? It probably should be returned as an error code. Andrew