On Mon, 31 Aug 2020 at 15:57, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > > On 31.08.2020 12:42, Krzysztof Kozlowski wrote: > > On Mon, 31 Aug 2020 at 12:35, Sylwester Nawrocki <snawrocki@xxxxxxxxxx> wrote: > >> On 8/31/20 10:38, Krzysztof Kozlowski wrote: > >>> On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > >>>> On 30.08.2020 15:51, Krzysztof Kozlowski wrote: > >>>>> The camera's pinctrl configuration is simply empty and not effective. > >>>>> Remove it to fix dtbs_check warning: > >>>>> > >>>>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' > >>>>> > >>>>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >>>> > >>>> I think that this was intentional to properly enable support for > >>>> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the > >>>> default values if no pinctrl properties are provided. Sylwester, could > >>>> you comment? > >>> > >>> Indeed it could be intentional... I see now errors: > >>> [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 > >>> > >>> I wonder why getting an empty pinctrl is needed... maybe the driver > >>> should accept missing pinctrl? > >> > >> It might have been better to have the pinctrl properties optional, as there > >> might be boards without the image sensor attached and FIMC could still be > >> used in memory-to-memory mode, as Marek pointed out. But it seems too late > >> now to change that. The binding defines the pinctrl properties as required > >> (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to > >> keep them in dtses. > > > > You can always make a required property optional and it is not a break > > of ABI. The other way around would be a break. Why then not changing > > the driver to accept optional pinctrl? > > Feel free to send the patch, I would prefer to leave that as is though. > Is it really suddenly a problem to use an empty property? The pinctrl > bindings allows it. The bindings scream: arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' so either we should model it differently (not as empty array), update the driver to make it optional or change the bindings/dtschema. I'll see how to fix it properly. Best regards, Krzysztof
