On Wed, 12 Aug 2020 11:30:28 -0500 David Lechner <david@xxxxxxxxxxxxxx> wrote: > On 8/9/20 6:17 AM, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Simple conversion. This binding already had the > > that is necessary, I'm happy to leave it as previously documented. > > This commit message doesn't make sense to me. It should probably > just say "this converts the device tree bindings to yml" or so. I'm not sure what happened there. I think perhaps a line got accidentally removed. It was meant to talk about the fact #io-channel-cells is marked as required which may not make sense for all boards with this part. Will rewrite for v2. Jonathan > > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Cc: David Lechner <david@xxxxxxxxxxxxxx> > > --- > > .../bindings/iio/adc/ti,ads7950.yaml | 64 +++++++++++++++++++ > > .../bindings/iio/adc/ti-ads7950.txt | 23 ------- > > 2 files changed, 64 insertions(+), 23 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml > > new file mode 100644 > > index 000000000000..a759d9064718 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7950.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Texas Instruments ADS7950 and similar ADCs > > + > > +maintainers: > > + - David Lechner <david@xxxxxxxxxxxxxx> > > + > > +description: | > > + Family of 4-16 channel, 8-12 bit ADCs with SPI interface. > > + > > +properties: > > + compatible: > > + enum: > > + - ti,ads7950 > > + - ti,ads7951 > > + - ti,ads7952 > > + - ti,ads7953 > > + - ti,ads7954 > > + - ti,ads7955 > > + - ti,ads7956 > > + - ti,ads7957 > > + - ti,ads7958 > > + - ti,ads7959 > > + - ti,ads7960 > > + - ti,ads7961 > > + > > + reg: > > + maxItems: 1 > > + > > + spi-max-frequency: true > > According to the datasheet, max frequency is 20MHz, so this can be: > > spi-max-frequency: > maximum: 20000000 > > > + > > + vref-supply: > > + description: Supply the 2.5V or 5V reference voltage > > Should this say "Supplies ..."? > > > + > > + "#io-channel-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - vref-supply > > + - "#io-channel-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + adc@0 { > > + compatible = "ti,ads7957"; > > + reg = <0>; > > + vref-supply = <&refin_supply>; > > + spi-max-frequency = <10000000>; > > + #io-channel-cells = <1>; > > + }; > > + }; > >
