Re: [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anand

(I haven't re-read all of this discussion, so apologies if something
in my reply doesn't make sense)

On Sat, Aug 29, 2020 at 6:31 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
[...]
> Just want to clear my confusion on RTC INT gpio setting is not needed.
> I did not find any other example to support this changes.
> So I have enable the debug logs on rtc-pcf8563.c with this current
> patch at my end.
my understanding is that your testing procedure is to simply use your
original patch and see if rtc wake-up is working.
since GPIOAO_7 is not explicitly mentioned in your testing procedure
I'm assuming that you're not configuring it anywhere.
Kevin's concern is what happens when that GPIO is configured
incorrectly (for example by some u-boot bug, firmware issue, ...). for
example: have you tried to configure GPIOAO_7 in u-boot as output low
pin and see if rtc wake-up is still working?

In your previous replies you mentioned various pin mux settings
related to TSIN_A_DIN0 //  TDMB_FS // TDMB_SLV_FS
I don't know how those are related to the RTC
My suggestion is to look at
arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi - it has a
eth_phy_irq_pins definition and apply something similar on Odroid-N2


Best regards,
Martin



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux