Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




+config SND_SOC_SC7180
+       tristate "SoC Machine driver for SC7180 boards"
+       depends on SND_SOC_QCOM

this depends is probably not necessary, the code is already in an if case.

+       select SND_SOC_QCOM_COMMON
+       select SND_SOC_LPASS_SC7180
+       select SND_SOC_MAX98357A
+       select SND_SOC_RT5682

I haven't done any significant testing / review of your patch (I'm
mostly sound-clueless), but I believe that the above needs to be
"select SND_SOC_RT5682_I2C" atop the current top of the sound tree.
When I fix that I can confirm that I see the rt5682 probe on
sc7180-trogdor with Rob Clark's dts patch.

Ack, no one should select SND_SOC_RT5682 directly in machine drivers. now that the code is split between I2C and SoundWire parts.

There should probably be a depends on I2C as well?



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux