Hi Andrew, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on linux/master linus/master v5.9-rc2 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andrew-Lunn/of-of_match_node-Make-stub-an-inline-function-to-avoid-W-1-warnings/20200828-102035 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-randconfig-a006-20200828 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/misc/atmel-ssc.c: In function 'atmel_ssc_get_driver_data': >> drivers/misc/atmel-ssc.c:137:25: error: 'atmel_ssc_dt_ids' undeclared (first use in this function); did you mean 'atmel_ssc_devtypes'? 137 | match = of_match_node(atmel_ssc_dt_ids, pdev->dev.of_node); | ^~~~~~~~~~~~~~~~ | atmel_ssc_devtypes drivers/misc/atmel-ssc.c:137:25: note: each undeclared identifier is reported only once for each function it appears in -- drivers/i2c/busses/i2c-s3c2410.c: In function 's3c24xx_get_device_quirks': >> drivers/i2c/busses/i2c-s3c2410.c:162:25: error: 's3c24xx_i2c_match' undeclared (first use in this function); did you mean 's3c24xx_i2c_state'? 162 | match = of_match_node(s3c24xx_i2c_match, pdev->dev.of_node); | ^~~~~~~~~~~~~~~~~ | s3c24xx_i2c_state drivers/i2c/busses/i2c-s3c2410.c:162:25: note: each undeclared identifier is reported only once for each function it appears in # https://github.com/0day-ci/linux/commit/3213d0cc82c7a4e0e85e0db3da3da279460c833b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrew-Lunn/of-of_match_node-Make-stub-an-inline-function-to-avoid-W-1-warnings/20200828-102035 git checkout 3213d0cc82c7a4e0e85e0db3da3da279460c833b vim +137 drivers/misc/atmel-ssc.c 099343c64e1615 Bo Shen 2012-11-07 131 7c97301285b62a Nathan Chancellor 2018-10-17 132 static inline const struct atmel_ssc_platform_data * 099343c64e1615 Bo Shen 2012-11-07 133 atmel_ssc_get_driver_data(struct platform_device *pdev) 099343c64e1615 Bo Shen 2012-11-07 134 { 099343c64e1615 Bo Shen 2012-11-07 135 if (pdev->dev.of_node) { 099343c64e1615 Bo Shen 2012-11-07 136 const struct of_device_id *match; 099343c64e1615 Bo Shen 2012-11-07 @137 match = of_match_node(atmel_ssc_dt_ids, pdev->dev.of_node); 099343c64e1615 Bo Shen 2012-11-07 138 if (match == NULL) 099343c64e1615 Bo Shen 2012-11-07 139 return NULL; 099343c64e1615 Bo Shen 2012-11-07 140 return match->data; 099343c64e1615 Bo Shen 2012-11-07 141 } 099343c64e1615 Bo Shen 2012-11-07 142 099343c64e1615 Bo Shen 2012-11-07 143 return (struct atmel_ssc_platform_data *) 099343c64e1615 Bo Shen 2012-11-07 144 platform_get_device_id(pdev)->driver_data; 099343c64e1615 Bo Shen 2012-11-07 145 } 099343c64e1615 Bo Shen 2012-11-07 146 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
