26.08.2020 14:50, Viresh Kumar пишет:
> We can now pass multiple versions in "opp-supported-hw" property, lets
> do that and simplify the tables a bit.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> ---
> Dmitry, I think there is further scope of simplifying stuff here by
> using the opp-microvolt-<name> property and corresponding
> dev_pm_opp_set_prop_name() call.
> ---
> .../boot/dts/tegra20-cpu-opp-microvolt.dtsi | 36 -
> arch/arm/boot/dts/tegra20-cpu-opp.dtsi | 67 +-
> .../boot/dts/tegra30-cpu-opp-microvolt.dtsi | 512 ---------
> arch/arm/boot/dts/tegra30-cpu-opp.dtsi | 986 +++---------------
> 4 files changed, 149 insertions(+), 1452 deletions(-)
Hello, Viresh!
Thank you very much! Very nice cleanup! I changed my OPP-gen tool to
produce the new OPP format and then comapared the result to yours
change, the result is matching.
...
> diff --git a/arch/arm/boot/dts/tegra30-cpu-opp.dtsi b/arch/arm/boot/dts/tegra30-cpu-opp.dtsi
...
> - opp@1000000000,975,3,7 {
> - clock-latency-ns = <100000>;
> - opp-supported-hw = <0x08 0x0080>;
> - opp-hz = /bits/ 64 <1000000000>;
> + opp-supported-hw = <0x0F 0x0001>,
> + <0x01 0x0002>,
> + <0x01 0x0010>,
> + <0x01 0x0080>,
> + <0x01 0x0100>;
> + opp-hz = /bits/ 64 <475000000>;
> };
The only very minor difference between my OPP-gen result and yours is
that the above hunk has inconsistent single-column formatting, while all
others are two-column.
Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx>
