> >> +module_param(comp, int, 0); > >> +MODULE_PARM_DESC(comp, "0=Non-Compression Mode, 1=Compression Mode"); > >> + > >> +module_param(ps_level, int, 0); > >> +MODULE_PARM_DESC(ps_level, > >> + "Power Saving Level (0:disable 1:level 1 2:level 2)"); > >> + > >> +module_param(msg_enable, int, 0); > >> +MODULE_PARM_DESC(msg_enable, "Message mask (see linux/netdevice.h for bitmap)"); > >> + > >> +static char *macaddr; > >> +module_param(macaddr, charp, 0); > >> +MODULE_PARM_DESC(macaddr, "MAC address"); > > > > I think MAC address as param is not accepted in mainline... > > > > $ git grep MODULE_PARM_DESC\(macaddr -- drivers/net | wc -l > 6 Yes, they exist. But still it is considered back practice, don't do it, use device tree for MAC addresses. Andrew