Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Date: Tue, 25 Aug 2020 10:55:27 -0700
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Kukjin Kim <kgene@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, m.szyprowski@xxxxxxxxxxx, b.zolnierkie@xxxxxxxxxxx
In-reply-to: <dleftjr1ruvdjd.fsf%l.stelmach@samsung.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

>>> +if NET_VENDOR_ASIX
>>> +
>>> +config SPI_AX88796C
>>> +	tristate "Asix AX88796C-SPI support"
>>> +	depends on SPI
>>
>> That line is redundant (but not harmful).
> 
> Why? Is it because NET_VENDOR_ASIX depends on SPI? Probably it
> shouldn't. Thanks for spotting.

Yes, that.


-- 
~Randy

References:
- Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
  - From: Randy Dunlap
- Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
  - From: Lukasz Stelmach

Prev by Date: Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support
Next by Date: Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support
Previous by thread: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Next by thread: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]