Hello, Le Mon, 24 Aug 2020 18:55:36 +0200, Maxime Ripard <maxime@xxxxxxxxxx> a écrit : > On Fri, Aug 21, 2020 at 04:59:29PM +0200, Kévin L'hôpital wrote: > > 10-bit bayer formats are aligned to 16 bits in memory, so this is > > what needs to be used as bpp for calculating the size of the > > buffers to allocate. > > > > Signed-off-by: Kévin L'hôpital <kevin.lhopital@xxxxxxxxxxx> > > Generally speaking, you should also explain why it's not an issue for > the callers. Depending on what that function is supposed to be doing > (returning the padded bits or the padded bits per pixel), your patch > could be either right or wrong. > > Since all the callers are using it to generate the number of bytes per > line, your patch is indeed correct. But it should be mentionned in the > commit log. > > Maxime All right, I will add this explanation. Thank you very much for the review Kévin -- Kevin L'Hopital, Bootlin Embedded Linux and kernel engineering https://bootlin.com
