On 06/10/2014 07:02 PM, Mark Brown wrote: > On Tue, Jun 10, 2014 at 08:59:01AM +0900, Chanwoo Choi wrote: >> On 06/10/2014 04:21 AM, Mark Brown wrote: > >>> If we're going to do that we'd need to define what modes mean in the DT >>> binding - currently there's no support for modes at all because it's >>> complicated to come up with sensible and meaningful generic defintions. > >> The 'regulator-mode' of this patch means following defined constant variable >> as following in include/linux/regulator/consumer.h: >> #define REGULATOR_MODE_FAST 0x1 >> #define REGULATOR_MODE_NORMAL 0x2 >> #define REGULATOR_MODE_IDLE 0x4 >> #define REGULATOR_MODE_STANDBY 0x8 > >> If regulator consumer would use this mode('regulator-mode), >> specific regulator driver should implement rdev->desc->ops->set_suspend_mode function >> to control regulator state according to 'regulator-mode' in suspend state. > > Sure, but what do those mean? > We could check basic explanation of regulator mode in include/linux/regulator/consumer.h. Should I add detailed descritpion of REGULATOR_MODE_* constant in drivers/regulator/of_regulator.c? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html