Hi Vaishnav, Apologies in advance -- I expect to be very slow in responding this week. Linux Plumbers will take some of my time and I am moving to a new home. -Frank On 2020-08-18 15:38, Frank Rowand wrote: > Hi Vaishnav, > > +me +devicetree > > Please add these two recipients to future versions. > > I will comment more after reading the first version and v2. > > -Frank > > > On 2020-08-18 07:48, Vaishnav M A wrote: >> Hi, >> >> This Patch series is an update to the mikroBUS driver >> RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 . >> The mikrobus driver is updated to add mikrobus ports from device-tree >> overlays, the debug interfaces for adding mikrobus ports through sysFS >> is removed, and the driver considers the extended usage of mikrobus >> port pins from their standard purposes. >> >> change log: >> v2: support for adding mikroBUS ports from DT overlays, >> remove debug sysFS interface for adding mikrobus ports, >> consider extended pin usage/deviations from mikrobus standard >> specifications, >> use greybus CPort protocol enum instead of new protcol enums >> Fix cases of wrong indendation, ignoring return values, freeing >> allocated resources in case of errors and other style suggestions >> in v1 review. >> >> Vaishnav M A (3): >> add mikrobus descriptors to greybus_manifest >> mikroBUS driver for add-on boards on mikrobus ports >> Add Device Tree Bindings for mikroBUS port >> >> .../bindings/misc/linux,mikrobus.txt | 81 ++ >> MAINTAINERS | 6 + >> drivers/misc/Kconfig | 1 + >> drivers/misc/Makefile | 1 + >> drivers/misc/mikrobus/Kconfig | 16 + >> drivers/misc/mikrobus/Makefile | 7 + >> drivers/misc/mikrobus/mikrobus_core.c | 692 ++++++++++++++++++ >> drivers/misc/mikrobus/mikrobus_core.h | 191 +++++ >> drivers/misc/mikrobus/mikrobus_manifest.c | 444 +++++++++++ >> drivers/misc/mikrobus/mikrobus_manifest.h | 21 + >> drivers/misc/mikrobus/mikrobus_port.c | 171 +++++ >> include/linux/greybus/greybus_manifest.h | 47 ++ >> 12 files changed, 1678 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/linux,mikrobus.txt >> create mode 100644 drivers/misc/mikrobus/Kconfig >> create mode 100644 drivers/misc/mikrobus/Makefile >> create mode 100644 drivers/misc/mikrobus/mikrobus_core.c >> create mode 100644 drivers/misc/mikrobus/mikrobus_core.h >> create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.c >> create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.h >> create mode 100644 drivers/misc/mikrobus/mikrobus_port.c >> >
