From: Helmut Grohne <helmut.grohne@xxxxxxxxxx> Date: Thu, 20 Aug 2020 08:03:33 +0200 > diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c > index 8d53b12d40a8..d96b7ab6bb15 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@ -389,6 +389,8 @@ int ksz_switch_register(struct ksz_device *dev, > { > phy_interface_t interface; > int ret; > + struct device_node *port; > + unsigned int port_num; > > if (dev->pdata) > dev->chip_id = dev->pdata->chip_id; Please preserve the reverse christmas tree ordering of local variables here.