On 4/15/20 8:56 PM, Alexandre Belloni wrote: > On 15/04/2020 18:37:00+0200, Bastian Krause wrote: >> Signed-off-by: Bastian Krause <bst@xxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/rtc/rtc-ds1307.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt >> index 66f0a31ae9ce..987a0c9e0cd7 100644 >> --- a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt >> +++ b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt >> @@ -34,6 +34,9 @@ Optional properties: >> - trickle-diode-disable : ds1339, ds1340 and ds 1388 only >> Do not use internal trickle charger diode >> Should be given if internal trickle charger diode should be disabled >> +- aux-voltage-chargeable: rx8130 only >> + Epsons's rx8130 supports a backup battery/supercap. >> + This flag tells whether the battery/supercap is chargeable or not. >> > > I think we should make that a generic property and this should supersede > trickle-diode-disable which is a bit wonky as I would prefer the default > to be disabled instead of enabled with the current semantics. Alright, I think I know how to transform the RTC drivers. One question about the DTs though: This means we should remove "trickle-diode-disable" from all upstream DTs and add "aux-voltage-chargeable" to all upstream DTs that use a RTC compatible whose driver care in their probe function for "trickle-diode-disable", right? Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
