Hi Shawn, Fabio > > > > > I would like to know your opinion, should I move headphone detect > > > GPIO To audmux group? > > > > What about adding a dedicated pinctrl_hp for the headphone detect pin > > like it is done at: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit. > > > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fshawnguo%2Flinux.g > it%2 > > Ftree%2Farch%2Farm64%2Fboot%2Fdts%2Ffreescale%2Fimx8mq- > librem5.dtsi%3F > > h%3Dfor- > next%26id%3D8f0216b006e5f553d28c4c1a991b5234693a49cb%23n130&am > > > p;data=02%7C01%7Cshengjiu.wang%40nxp.com%7C672e70414ead4170b617 > 08d847c > > > 05117%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63733823860 > 3810133& > > > amp;sdata=69K7rVsYB35Iq%2FdE%2FSf2%2B862VlwOFRwSTYBML7OQxUE%3 > D&res > > erved=0 > > > > My point is that we should avoid adding a hog group when possible. > > I agree. Hog group should be used as the last sort, when there is no clear > client device owning the pins. > Ok, thanks. I have sent v2. That I refined three patches for this topic. ARM: dts: imx6sx-sdb: Add headphone detection for sound card ARM: dts: imx6sl-evk: Add headphone detection for sound card ARM: dts: imx6sll-evk: Add audio sound card node Best regards Wang shengjiu
