On Sun, Aug 23, 2020 at 05:08:44PM +0300, Dmitry Osipenko wrote: > The ENE KB930 hardware is compatible with KB3930. > > Acer A500 Iconia Tab is Android tablet device, it has KB930 controller > that is running firmware specifically customized for the needs of the > Acer A500 hardware. This means that firmware interface isn't re-usable > by other non-Acer devices. Some akin models of Acer tablets should be > able to re-use the FW interface of A500 model, like A200 for example. > > This patch adds the new compatibles to the binding. I've responded to patch 5/6 with what should've been said here [1]. Sorry for the confusion. In any case please consider adding a new binding file instead of modifying the kb3930 binding doc. It would also remove a dependency on my patch set which should have slipped out of maintainers' radar. [1] https://lore.kernel.org/lkml/20200823180041.GB209852@demiurge.local/ Take care Lubo > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > Documentation/devicetree/bindings/mfd/ene-kb3930.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > index 074243c40891..5a1c4a959d9c 100644 > --- a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > +++ b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > @@ -17,8 +17,11 @@ properties: > compatible: > items: > - enum: > + - acer,a500-iconia-ec # Acer A500 Iconia tablet device > - dell,wyse-ariel-ec # Dell Wyse Ariel board (3020) > - - const: ene,kb3930 > + - enum: > + - ene,kb3930 > + - ene,kb930 > reg: > maxItems: 1 > > -- > 2.27.0 >
