On Fri, Aug 21, 2020 at 05:14:29PM +0800, Tanwar, Rahul wrote: > On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM controller does not have any other consumer, it is a > >> dedicated PWM controller for fan attached to the system. Add > >> driver for this PWM fan controller. > > ... > > +#include <linux/bitfield.h> > > +#include <linux/clk.h> > > +#include <linux/module.h> > >> +#include <linux/of_device.h> > > This should be mod_devicetable.h. > > Inlcuding mod_devicetable.h instead of of_device.h results in > build failure related to all platform calls. Build is ok if > i remove it. Just FYI.. I didn't get what the change you performed, by there is no users of of_device.h in your code. If build fails it means you need to figure out proper list of what has to be included. -- With Best Regards, Andy Shevchenko
