Re: [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/19/20 11:05 PM, Linus Walleij wrote:
On Thu, Aug 13, 2020 at 11:06 PM Jacek Anaszewski
<jacek.anaszewski@xxxxxxxxx> wrote:

+  led:
+    type: object
+    $ref: common.yaml#
(...)
+        led {
+            function = LED_FUNCTION_FLASH;
+            color = <LED_COLOR_ID_WHITE>;
+            flash-max-timeout-us = <250000>;

Constraints for this property are needed above.

Can you elaborate on what you expect this to look like?
The property is from common.yaml, so should that be
extended with a constraint?

Constraints are specific to the hardware, so those should
be provided in the related bindings.
Generally it is customary in similar cases to give min, max
and step values.

I don't have json-schema example, but see old txt DT bindings:

- Documentation/devicetree/bindings/leds/leds-lm3601x.txt
- Documentation/devicetree/bindings/mfd/max77693.txt

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux