On Wed, Aug 12, 2020 at 5:46 PM Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Aug 12, 2020 at 2:58 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > > Let's use a common.yaml include for the backlight like we do with > > the LEDs. The LEDs are inherently incompatible so their bindings > > cannot be reused for backlight. > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > Suggested-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > ChangeLog v1->v2: > > - New patch as suggested by Sam. > > --- > > .../bindings/leds/backlight/common.yaml | 42 +++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/backlight/common.yaml > > I'd expect some refactoring here with existing backlight schemas > including the ones I just added for 5.9. Yeah if it takes off I can certainly make a slew of refactorings, I would like to do that once this is applied. > > + LED powered by a boost converter. > > + > > +properties: > > + default-on: > > + description: > > + The initial state of the backlight can be set to be on with this > > + property. This is a state applied by the operating system so that the > > + backlight is always turned on at boot. > > Needs a type. Dropping this property because the subsystem maintainer doubts this is needed. Fixed the rest! Yours, Linus Walleij
