On 8/19/20 8:36 AM, Rafał Miłecki wrote: > On Wed, 19 Aug 2020 at 06:23, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: >> The pin controller resources start at 0xc0 from the CRU base which is at >> 0x100 from th DMU base, for a final address of 0x1800_c1c0, whereas we >> are currently off by 0x100. The resource size of the CRU is also >> incorrect and should end at 0x248 bytes from 0x100 which is the start >> address. Finally, the compatibility strings defined for the >> pin-controller node should reflect the SoC being used. >> >> Fixes: 9994241ac97c ("ARM: dts: BCM5301X: Describe Northstar pins mux controller") > > Let me verify that fix. I'm confused as I believe I got pinctrl > working for uart1 :| Sure, please let me know what you find. Chances are that UART1 was already pinmuxed corectly by the boot loader for your device and this could have turned out as a no-op. -- Florian