Hi, Thanks for your review. On Mon, Aug 17, 2020 at 01:48:33PM -0600, Rob Herring wrote: > On Mon, Aug 17, 2020 at 10:46:25AM +0900, Nobuhiro Iwamatsu wrote: > > Add pinctrl bindings for Toshiba Visconti TMPV7700 SoC series. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > .../pinctrl/toshiba,visconti-pinctrl.yaml | 82 +++++++++++++++++++ > > 1 file changed, 82 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml > > new file mode 100644 > > index 000000000000..4009902cd396 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml > > @@ -0,0 +1,82 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pinctrl/toshiba,visconti-pinctrl.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti TMPV770x pin mux/config controller > > + > > +maintainers: > > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > + > > +description: > > + Toshiba's Visconti ARM SoC a pin mux/config controller. > > + > > +properties: > > + compatible: > > + enum: > > + - toshiba,tmpv7708-pinctrl > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +patternProperties: > > + '^.*$': > > For new bindings, please define something like '-pins$' for the pin > nodes. OK, I will update. > > > + if: > > + type: object > > + then: > > Then we don't have to do this if/then. > > This also needs a $ref to the common pinctrl schemas. > OK, I will fix this. > > + properties: > > + function: > > + description: > > + Function to mux. > > + $ref: "/schemas/types.yaml#/definitions/string" > > + enum: [i2c0, i2c1, i2c2, i2c3, i2c4, i2c5, i2c6, i2c7, i2c8, > > + spi0, spi1, spi2, spi3, spi4, spi5, spi6, > > + uart0, uart1, uart2, uart3, pwm, pcmif_out, pcmif_in] > > + Best regards, Nobuhiro
