Hi Christian and Jerome, Thanks for the review comments.. On Tue, 18 Aug 2020 at 13:21, Christian Hewitt <christianshewitt@xxxxxxxxx> wrote: > > > > > On 18 Aug 2020, at 11:45 am, Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote: > > > > > > On Mon 17 Aug 2020 at 12:21, Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > > >> Disable virtual RTC node on Odroid N2, > >> since RTC PCF8563 support rtc wakeup. > >> > >> [ 7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0 > >> [ 7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7) > >> > > > > Maybe I'm missing something but why should disable this ? > > Can't the 2 RTCs co-exist ? > > aliases { > serial0 = &uart_AO; > ethernet0 = ðmac; > rtc1 = &vrtc; > }; > > ^ adding this alias moves vrtc to /dev/rtc1 allowing the on-board rtc to > assume /dev/rtc0 which scripts/users and HOWTO guides assume to be a > real clock device. Tested and working fine with my own experiments with > enabling rtc on a bunch of G12B/SM1 boards. > > Christian I will drop this patch and add the alias in the next version. -Anand