Hi Anand,
thank you for updating this patch!
On Mon, Aug 17, 2020 at 12:21 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
[...]
> changes v2
> --Fix the missing INT (GPIOA.BIT7) pinctrl.
should I also expect an interrupt property somewhere below?
> --Fix the missing rtcwakeup.
> --Drop the clock not required clock property by the PCF8563 driver.
> ---
> .../arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 34fffa6d859d..f08ae1b337ad 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -477,6 +477,19 @@ hdmi_tx_tmds_out: endpoint {
> };
> };
>
> +&i2c3 {
> + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
> + pinctrl-1 = <&tdm_c_din3_a_pins>;
> + pinctrl-names = "default";
why is there pinctrl-1 without any corresponding "pinctrl-names" entry?
also I'm surprised to see a TDM (audio) related pin function as part
of an I2C controller. if this is correct then I'd appreciate a bit
information (for example as part of the patch description) why that is
Martin
