Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

[kernel test robot <lkp@xxxxxxxxx>]

Hi Amireddy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on v5.8 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amireddy-Mallikarjuna-reddy/Add-Intel-LGM-soc-DMA-support/20200814-134726
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/dma/lgm/lgm-dma.c:1570:5: warning: no previous prototype for 'update_client_configs' [-Wmissing-prototypes]
    1570 | int update_client_configs(struct of_dma *ofdma, struct of_phandle_args *spec)
         |     ^~~~~~~~~~~~~~~~~~~~~

vim +/update_client_configs +1570 drivers/dma/lgm/lgm-dma.c

  1569	
> 1570	int update_client_configs(struct of_dma *ofdma, struct of_phandle_args *spec)
  1571	{
  1572		struct ldma_dev *d = ofdma->of_dma_data;
  1573		struct ldma_port *p;
  1574		struct ldma_chan *c;
  1575		u32 chan_id =  spec->args[0];
  1576		u32 port_id =  spec->args[1];
  1577	
  1578		if (chan_id >= d->chan_nrs || port_id >= d->port_nrs)
  1579			return 0;
  1580	
  1581		p = &d->ports[port_id];
  1582		c = &d->chans[chan_id];
  1583	
  1584		if (d->ver == DMA_VER22) {
  1585			u32 burst = spec->args[2];
  1586	
  1587			if (burst != 2 && burst != 4 && burst != 8)
  1588				return 0;
  1589	
  1590			/* TX and RX has the same burst length */
  1591			p->txbl = ilog2(burst);
  1592			p->rxbl = p->txbl;
  1593	
  1594			ldma_port_cfg(p);
  1595		} else {
  1596			if (spec->args[2] > 0 && spec->args[2] <= DMA_ENDIAN_TYPE3) {
  1597				c->data_endian = spec->args[2];
  1598				c->data_endian_en = true;
  1599			}
  1600	
  1601			if (spec->args[3] > 0 && spec->args[3] <= DMA_ENDIAN_TYPE3) {
  1602				c->desc_endian = spec->args[3];
  1603				c->desc_endian_en = true;
  1604			}
  1605	
  1606			if (spec->args[4] > 0 && spec->args[4] < 128)
  1607				c->boff_len = spec->args[4];
  1608	
  1609			if (spec->args[5])
  1610				c->desc_rx_np = true;
  1611	
  1612			/*
  1613			 * If channel packet drop enabled, port packet drop should
  1614			 * be enabled
  1615			 */
  1616			if (spec->args[6]) {
  1617				c->pden = true;
  1618				p->pkt_drop = DMA_PKT_DROP_EN;
  1619			}
  1620			ldma_port_cfg(p);
  1621			ldma_chan_cfg(c);
  1622		}
  1623	
  1624		return 1;
  1625	}
  1626	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip