Thanks for your reply. I have changed this in v2 patch. On Wed, 2020-08-12 at 14:03 +0200, Philipp Zabel wrote: > On Wed, 2020-08-12 at 17:37 +0800, Wenbin Mei wrote: > > Add description for resets/reset-names. > > > > Signed-off-by: Wenbin Mei <wenbin.mei@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 8a532f4453f2..35da72de7aac 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -49,6 +49,8 @@ Optional properties: > > error caused by stop clock(fifo full) > > Valid range = [0:0x7]. if not present, default value is 0. > > applied to compatible "mediatek,mt2701-mmc". > > +- resets: Phandle and reset specifier pair to softreset line of MSDC IP. > > +- reset-names: Reset names for MSDC. > > I think the reset-names documentation should mention the actual value > the driver should look for, "hrst". > > regards > Philipp
