Hi Linus. On Wed, Aug 12, 2020 at 08:48:42AM +0200, Linus Walleij wrote: > On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > > +description: | > > > + The Kinetic Technologies KTD253 is a white LED backlight that is > > > + controlled by a single GPIO line. If you just turn on the backlight > > > + it goes to maximum backlight then you can set the level of backlight > > > + using pulses on the enable wire. > > > > No $ref for common.yaml? > > Since this is a backlight, and we do not have common bindings for, > backlight I first looked into using the LED bindings in > ../common.yaml, but that has several problems, it cannot really > be used for backlight. Backlight doesn't have "triggers", > patterns, flash properties, the function is also pretty much > evident. > > So I will look into creating a new common for backlight. Hmm, I think I looked at leds/ when I wrote that comment about common.yaml. Please consider Rob's comment in commit: 44e1655a444fe7a1bd81994d34c6bbb5245b9e60 ("dt-bindings: backlight: Convert common backlight bindings to DT schema") Rob did not see the need for a common binding - but that may change as we add more backlight bindings. Sam