Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pavel

On 8/11/20 5:01 PM, Pavel Machek wrote:
Hi!

Actually... This is quite impressive ammount of code to
zero-initialize few registers. Could the regmap be told to set the
range to zero, or use loops to reduce ammount of code?
I am not aware of any regmap calls that will set a range of registers to a
certain value.

Well it depends on where we want to create the default cache values.

Either we run through a for..loop during driver probe and delay device start
up or we keep the simple arrays and increase the driver total size.
for loop will be better.

Plus, REGCACHE_RBTREE is very likely overkill.

Well if I eliminate the reg_cache then I can eliminate the defaults too.

Dan

Best regards,

									Pavel



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux