RE: [PATCH] dt-bindings: gpio: Convert vf610 to json-schema

Anson Huang <anson.huang@xxxxxxx> · Fri, 7 Aug 2020 01:54:02 +0000

Hi, Rob

> Subject: Re: [PATCH] dt-bindings: gpio: Convert vf610 to json-schema
> 
> On Tue, 04 Aug 2020 23:01:48 +0800, Anson Huang wrote:
> > Convert the vf610 gpio binding to DT schema format using json-schema.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> >  .../devicetree/bindings/gpio/gpio-vf610.txt        | 63 -----------------
> >  .../devicetree/bindings/gpio/gpio-vf610.yaml       | 79
> ++++++++++++++++++++++
> >  2 files changed, 79 insertions(+), 63 deletions(-)  delete mode
> > 100644 Documentation/devicetree/bindings/gpio/gpio-vf610.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> >
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/
> gpio-vf610.example.dt.yaml: example-0: gpio@40049000:reg:0: [1074040832,
> 4096, 1074786304, 64] is too long
> 

I updated the dt-schema and the latest commit is as below, and there is no build error
on my side, do you know why?

commit 8fd8ce7ff6bd47616ceb48f69d1a04116dee7a41
Author: Rob Herring <robh@xxxxxxxxxx>
Date:   Wed Aug 5 10:38:08 2020 -0600

    dt-extract-example: Use the C yaml parser

    The 'pure' (Python) loader was needed at one time for YAML 1.2, but ruamel
    has supported 1.2 with its libyaml since 0.15.63 and we depend on version
    0.15.70 at least.

    Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

tools/dt-extract-example

anson@anson-OptiPlex-790:~/workspace/stash/linux-next$ make.cross ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
make CROSS_COMPILE=/opt/gcc-4.9.0-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- --jobs=8 ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
  CHKDT   Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema-examples.yaml
/home/anson/workspace/stash/linux-next/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml: ignoring, error in schema: additionalProperties
warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
  DTC     Documentation/devicetree/bindings/gpio/gpio-vf610.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/gpio/gpio-vf610.example.dt.yaml
anson@anson-OptiPlex-790:~/workspace/stash/linux-next$

Thanks,
Anson