Re: [PATCH v2 1/4] dt-bindings: media: i2c: ov5640: Document bus-type property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

Thank you for the review.

On Tue, Aug 4, 2020 at 9:15 AM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thanks for the update.
>
> On Mon, Aug 03, 2020 at 03:31:44PM +0100, Lad Prabhakar wrote:
> > Document the possible bus-type's supported by the OV5640 sensor driver.
> >
> > Also add the bus-type in example node.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/ov5640.txt | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> > index c97c2f2da12d..00131dbb147e 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> > @@ -36,9 +36,15 @@ Endpoint node required properties for parallel connection are:
> >  - data-shift: shall be set to <2> for 8 bits parallel bus
> >             (lines 9:2 are used) or <0> for 10 bits parallel bus
> >  - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
> > +             (Required for bus-type 5)
> >  - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
> > +             (Required for bus-type 5)
> >  - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
> > -            signal.
> > +            signal. (Required for bus-type 5)
> > +- bus-type: data bus type. Possible values are:
> > +         4 - MIPI CSI-2 D-PHY
> > +         5 - Parallel
> > +         6 - Bt.656
>
> This is under required parallel properties. You could document value 4
> under CSI-2 related properties.
>
Agreed will do that.

Cheers,
Prabhakar

> >
> >  Examples:
> >
> > @@ -86,6 +92,7 @@ Examples:
> >                               hsync-active = <0>;
> >                               vsync-active = <0>;
> >                               pclk-sample = <1>;
> > +                             bus-type = <5>;
> >                       };
> >               };
> >       };
>
> --
> Regards,
>
> Sakari Ailus



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux