Hi Lv, On 2014-6-5 8:56, Zheng, Lv wrote: > Hi, Lee > >> From: Lee Jones [mailto:lee.jones@xxxxxxxxxx] >> Sent: Wednesday, June 04, 2014 8:10 PM >> >> Any drivers which support ACPI and Device Tree probing need to include >> both respective header files. Without this patch, if a driver is being >> used on a platform which does not support ACPI and subsequently does not >> have the config option enabled, but includes linux/acpi.h the build >> breaks with: >> >> In file included from ../include/acpi/platform/acenv.h:150:0, >> from ../include/acpi/acpi.h:56, >> from ../include/linux/match.h:2, >> from ../drivers/i2c/i2c-core.c:43: >> ../include/acpi/platform/aclinux.h:73:23: >> fatal error: asm/acenv.h: No such file or directory >> #include <asm/acenv.h> >> ^ >> Cc: Lv Zheng <lv.zheng@xxxxxxxxx> >> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >> Cc: linux-acpi@xxxxxxxxxxxxxxx >> Cc: devel@xxxxxxxxxx >> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> >> --- >> include/acpi/platform/aclinux.h | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h >> index cd1f052..fdf7663 100644 >> --- a/include/acpi/platform/aclinux.h >> +++ b/include/acpi/platform/aclinux.h >> @@ -70,9 +70,10 @@ >> #ifdef EXPORT_ACPI_INTERFACES >> #include <linux/export.h> >> #endif >> -#include <asm/acenv.h> >> >> -#ifndef CONFIG_ACPI >> +#ifdef CONFIG_ACPI >> +#include <asm/acenv.h> >> +#else > > This is exactly what I want to do in the next step. > But you are a bit faster here. > I believe: > The miss-ordered inclusions of <asm/acpi.h> is the culprit of all of the miss-ordered inclusions in arch/x86/include/asm. > You should have noted that <asm/acpi.h> was originally unexpected included by some x86 specific headers. > Simply doing <asm/acenv.h> exlusion in this way might be able to fix your issue for your architecture, but it could be very likely breaking x86 builds. > You might be able to find another way to solve your build issue - for example, creating an empty <asm/acenv.h> for arch/arm. Yes, we solve this issue as you suggested for arch/arm64. since ARM32 will not support ACPI in the near future, we may find another way to fix it. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
