Re: [PATCH v10 00/28] Add support for mt2701 JPEG ENC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Xia,

On Thu, Jul 23, 2020 at 11:04:23AM +0800, Xia Jiang wrote:
> This patchset add support for mt2701 JPEG ENC support.      
>                                                             
> This is the compliance test result for jpeg dec and enc.    
>                                                             
> The JPEG dec log:                                           
> ------------------------------------------------------------
> v4l2-compliance -d /dev/video0
> v4l2-compliance SHA: 697ae940b60a172ef31948dd74316fe9de365b7e, 32 bits, 32-bit time_t
> 
> Compliance test for mtk-jpeg-dec device /dev/video0:
> 
> Driver Info:
>         Driver name      : mtk-jpeg-dec
>         Card type        : mtk-jpeg-dec
>         Bus info         : platform:15004000.jpegdec
>         Driver version   : 5.8.0
>         Capabilities     : 0x84204000
>                 Video Memory-to-Memory Multiplanar
>                 Streaming
>                 Extended Pix Format
>                 Device Capabilities
>         Device Caps      : 0x04204000
>                 Video Memory-to-Memory Multiplanar
>                 Streaming
>                 Extended Pix Format
>         Detected JPEG Decoder
> 
> Required ioctls:
>         test VIDIOC_QUERYCAP: OK
> 
> Allow for multiple opens:
>         test second /dev/video0 open: OK
>         test VIDIOC_QUERYCAP: OK
>         test VIDIOC_G/S_PRIORITY: OK
>         test for unlimited opens: OK
> 
>         test invalid ioctls: OK
> Debug ioctls:
>         test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>         test VIDIOC_LOG_STATUS: OK (Not Supported)
> 
> Input ioctls:
>         test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>         test VIDIOC_ENUMAUDIO: OK (Not Supported)
>         test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>         test VIDIOC_G/S_AUDIO: OK (Not Supported)
>         Inputs: 0 Audio Inputs: 0 Tuners: 0
> 
> Output ioctls:
>         test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>         test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>         test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>         Outputs: 0 Audio Outputs: 0 Modulators: 0
> 
> Input/Output configuration ioctls:
>         test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>         test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>         test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>         test VIDIOC_G/S_EDID: OK (Not Supported)
> 
> Control ioctls:
>         test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>         test VIDIOC_QUERYCTRL: OK
>         test VIDIOC_G/S_CTRL: OK
>         test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>         test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported)
>         test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>         Standard Controls: 0 Private Controls: 0
> 
> Format ioctls:
>         test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>         test VIDIOC_G/S_PARM: OK (Not Supported)
>         test VIDIOC_G_FBUF: OK (Not Supported)
>         test VIDIOC_G_FMT: OK
>         test VIDIOC_TRY_FMT: OK
>         test VIDIOC_S_FMT: OK
>         test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>         test Cropping: OK (Not Supported)
>         test Composing: OK
>         test Scaling: OK (Not Supported)
> 
> Codec ioctls:
>         test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>         test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>         test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
> 
> Buffer ioctls:
>         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>         test VIDIOC_EXPBUF: OK
>         test Requests: OK (Not Supported)
> 
> Total for mtk-jpeg-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
> ------------------------------------------------------------
>                                                             
> The JPEG enc log:                                           
>                                                             
> ------------------------------------------------------------
> v4l2-compliance -d /dev/video1 
> v4l2-compliance SHA: 697ae940b60a172ef31948dd74316fe9de365b7e, 32 bits, 32-bit time_t
> 
> Compliance test for mtk-jpeg-enc device /dev/video1:
> 
> Driver Info:
>         Driver name      : mtk-jpeg-enc
>         Card type        : mtk-jpeg-enc
>         Bus info         : platform:1500a000.jpegenc
>         Driver version   : 5.8.0
>         Capabilities     : 0x84204000
>                 Video Memory-to-Memory Multiplanar
>                 Streaming
>                 Extended Pix Format
>                 Device Capabilities
>         Device Caps      : 0x04204000
>                 Video Memory-to-Memory Multiplanar
>                 Streaming
>                 Extended Pix Format
>         Detected JPEG Encoder
> 
> Required ioctls:
>         test VIDIOC_QUERYCAP: OK
> 
> Allow for multiple opens:
>         test second /dev/video1 open: OK
>         test VIDIOC_QUERYCAP: OK
>         test VIDIOC_G/S_PRIORITY: OK
>         test for unlimited opens: OK
> 
>         test invalid ioctls: OK
> Debug ioctls:
>         test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>         test VIDIOC_LOG_STATUS: OK (Not Supported)
> 
> Input ioctls:
>         test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>         test VIDIOC_ENUMAUDIO: OK (Not Supported)
>         test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>         test VIDIOC_G/S_AUDIO: OK (Not Supported)
>         Inputs: 0 Audio Inputs: 0 Tuners: 0
> 
> Output ioctls:
>         test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>         test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>         test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>         Outputs: 0 Audio Outputs: 0 Modulators: 0
> 
> Input/Output configuration ioctls:
>         test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>         test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>         test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>         test VIDIOC_G/S_EDID: OK (Not Supported)
> 
> Control ioctls:
>         test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>         test VIDIOC_QUERYCTRL: OK
>         test VIDIOC_G/S_CTRL: OK
>         test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>         test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>         test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>         Standard Controls: 4 Private Controls: 0
> 
> Format ioctls:
>         test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>         test VIDIOC_G/S_PARM: OK (Not Supported)
>         test VIDIOC_G_FBUF: OK (Not Supported)
>         test VIDIOC_G_FMT: OK
>         test VIDIOC_TRY_FMT: OK
>         test VIDIOC_S_FMT: OK
>         test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>         test Cropping: OK
>         test Composing: OK (Not Supported)
>         test Scaling: OK (Not Supported)
> 
> Codec ioctls:
>         test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>         test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>         test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
> 
> Buffer ioctls:
>         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>         test VIDIOC_EXPBUF: OK
>         test Requests: OK (Not Supported)
> 
> Total for mtk-jpeg-enc device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0
> ------------------------------------------------------------
> 
> Change compared to v9:
> - use pm_runtime_force_*()helpers of patch 07/28
> - add one patch for handling jpeg hardware's locking up
> - delete mtk_jpeg_qbuf() in patch 09/28
> - add one patch for deletting vidioc_s_selection ioctl of jpeg dec
> - add one patch for changing the maximum width and height supported by jpeg dec
> - add one patch for refactoring mtk_jpeg_try_fmt_mplane function
> - add one patch for refactoring mtk_jpeg_find_format function
> - add one patch for redefinition of mtk_jpeg_q_data structure
> - add one patch for changing the colorspace of jpeg to the fixed value
> - add one patch for refactoring mtk_jpeg_set_default_params function
> - add one patch for changing the call function of getting/enable/disable the jpeg's clock
> - add one patch for using the variant structure to contain the varability between jpeg dec and enc
> - return active crop information in mtk_jpeg_enc_g_selection function
> - cancel mtk_jpeg_enc_bs structure
> - refactor the setting hardware register functions in mtk_jpeg_enc_hw.c
> - remove mtk_jpeg_enc_job_ready function
> - refactor mtk_jpeg_enc_irq function
> - cancel setting up a control handler for jpeg dec
> - add the mechanism to ensure that the buffer is enough to hold the EXIF data in .buf_prepare callback
> 
> Xia Jiang (28):
>   media: platform: Improve subscribe event flow for bug fixing
>   media: platform: Improve queue set up flow for bug fixing
>   media: platform: Improve getting and requesting irq flow for bug
>     fixing
>   media: platform: Change the fixed device node number to unfixed value
>   media: platform: Improve power on and power off flow
>   media: platform: Delete the resetting hardware flow in the system PM
>     ops
>   media: platform: Improve the implementation of the system PM ops
>   media: platform: Add mechanism to handle jpeg hardware's locking up
>   media: platform: Cancel the last frame handling flow
>   media: platform: Delete zeroing the reserved fields
>   media: platform: Stylistic changes for improving code quality
>   media: platform: Use generic rounding helpers
>   media: platform: Change MTK_JPEG_COMP_MAX macro definition location
>   media: platform: Delete redundant code and add annotation for an enum
>   media: platform: Delete vidioc_s_selection ioctl of jpeg dec
>   media: platform: Change the maximum width and height supported by JPEG
>     dec
>   media: platform: Refactor mtk_jpeg_try_fmt_mplane()
>   media: platform: Refactor mtk_jpeg_find_format()
>   media: platform: Redefinition of mtk_jpeg_q_data structure
>   media: platform: Change the colorspace of jpeg to the fixed value
>   media: platform: Refactor mtk_jpeg_set_default_params()
>   media: platform: Change the call functions of getting/enable/disable
>     the jpeg's clock

Except one comment to that one patch, the series looks good to me. After
fixing that last comment, feel free to add my Reviewed-by to all the
patches which still don't have it.

Thanks a lot for patiently addressing the comments. I think the series
improves the driver a lot.

Best regards,
Tomasz



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux