On Thu, Jul 30, 2020 at 04:55:33PM +0300, Serge Semin wrote:
> Since GPIOlib-based IRQ-chip interface is now utilized there is no need
> in calling the methods acpi_gpiochip_{request,free}_interrupts() here.
> They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove()
> anyway.
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx>
>
> ---
>
> Changelog v2:
> - This is a new patch detached from commit
> "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
> ---
> drivers/gpio/gpio-dwapb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index f7acc5abbf5c..226d9c2d9493 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -512,9 +512,6 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> return err;
> }
>
> - /* Add GPIO-signaled ACPI event support */
> - acpi_gpiochip_request_interrupts(&port->gc);
> -
> port->is_registered = true;
>
> return 0;
> @@ -530,7 +527,6 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
> if (!port->is_registered)
> continue;
>
> - acpi_gpiochip_free_interrupts(&port->gc);
> gpiochip_remove(&port->gc);
> }
> }
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
