Hi Rob, On Wed, 29 Jul 2020 at 04:18, Rob Herring <robh@xxxxxxxxxx> wrote: > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - mstar,pmsleep > > Needs to be SoC specific. Random collections of bits are never > 'standard' from one SoC to the next. I don't have a manual for any of the chips so I can't say for sure but so far all of the chips in this group (ARMv7 based MStar/Sigmastar) has the same layout for the registers i.e. the reset register, the resume address registers are at the same place for all of them. Does calling it "mstar,pmsleepv7" make more sense? I'm not sure what to call it really. > If your never going to have child nodes, then you can just add the > compatible to syscon.yaml. Considering the above would it make sense to drop the specific compatible string for now and just leave it as syscon until there is a reason to make it more specific? Thanks, Daniel
