Hi, Seiya:
On Wed, 2020-07-29 at 16:02 +0800, CK Hu wrote:
> Hi, Seiya:
>
> On Wed, 2020-07-29 at 09:30 +0800, Seiya Wang wrote:
> > Add basic chip support for Mediatek MT8192
> >
> > Signed-off-by: Seiya Wang <seiya.wang@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/mediatek/Makefile | 1 +
> > arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 29 ++
> > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 671 ++++++++++++++++++++++++++++
> > 3 files changed, 701 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-evb.dts
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192.dtsi
> >
>
> [snip]
>
> > +
> > + watchdog: watchdog@10007000 {
> > + compatible = "mediatek,mt6589-wdt";
>
> According to [1] and [2], compatible string for mt8192 watch dog should
> be "mediatek,mt6873-wdt","mediatek,mt8192-wdt".
>
>
> [1]
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2287090/12
> [2]
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2131598/18
>
> > + reg = <0 0x10007000 0 0x100>;
> > + #reset-cells = <1>;
> > + };
> > +
>
> [snip]
>
> > +
> > + mmsys: mmsys@14000000 {
> > + compatible = "mediatek,mt8192-mmsys", "syscon";
>
> You should define "mediatek,mt8192-mmsys" first, then you could use it
> in this patch
Sorry, this series depend on [1], but mmsys is a syscon, so this should
be
mmsys: syscon@14000000 {
[1]
http://lists.infradead.org/pipermail/linux-mediatek/2020-July/014451.html
Regards,
CK
> .
>
> Regards,
> CK
>
> > + reg = <0 0x14000000 0 0x1000>;
> > + #clock-cells = <1>;
> > + };
> > +
>
