On 20.07.2020 16:34, Krzysztof Kozlowski wrote:
> On Fri, Jul 10, 2020 at 07:35:00PM +0200, Sylwester Nawrocki wrote:
>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> @@ -175,3 +175,41 @@
>> gpio = <&gpm0 0 GPIO_ACTIVE_HIGH>;
>> status = "okay";
>> };
>> +
>> +&submic_bias_reg {
>
> Put them in alphabetical order against oder phandle overrides. Same for
> n710x.dts.
>> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
>> @@ -102,6 +102,30 @@
>> status = "disabled";
>> };
>>
>> + vbatt_reg: voltage-regulator-9 {
>
> Since this is the basic DTSI for multiple boards, the numbering here
> should be consistent. You will have to rename the ones in Galaxy S3 and
> N710 DTSI.
>> @@ -266,16 +290,18 @@
>> + cpu {
>> + sound-dai = <&i2s0 0>;
>
> Double space after '='.
Thanks for your review, I have addressed all these issues in just
posted v2.
--
Regards,
Sylwester
