On Thu, Jul 23, 2020 at 03:45:48PM -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2020-06-26 04:54:33)
> > The RaspberryPi firmware binding uses two compatible, include simple-bus.
> > The select statement generated by default will thus select any node that
> > has simple-bus, not all of them being the raspberrypi firmware node.
> >
> > This results in warnings being wrongfully reported. Let's add a custom
> > select statement to fix that.
> >
> > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
> >
> > ---
> >
> > The original binding has been merged through the clock tree, so it should
> > be merged there.
> >
> > Even though the original binding (and the DT) are using the simple-bus
> > compatible, this creates some DTC warnings since the firmware really isn't
> > a bus, so the node name doesn't match what a bus should have, none of the
> > children have a reg property, #address-cells and #size-cells are missing,
> > etc.
> >
> > I can only guess that simple-bus was used to make the sub-devices probe,
> > but maybe simple-mfd would be more appropriate here?
> > ---
> > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> Hmm. I'm still seeing warnings.
>
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp
> ty reg/ranges property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
Yeah, those are the warnings related to the issue we were discussing
with Rob. The patch should fix an hard error.
I'll send a followup patch for the warnings.
Thanks!
Maxime
Attachment:
signature.asc
Description: PGP signature
