Hi Marek. On Sun, Jul 26, 2020 at 12:17:46PM +0200, Marek Vasut wrote: > On 7/26/20 9:15 AM, Sam Ravnborg wrote: > > Hi Marek. > > Hi, > > > On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote: > >> Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived > >> from tc358764 driver and panel-raspberrypi-touchscreen. This driver is > >> meant to replace the panel-raspberrypi-touchscreen too, as the bridge > >> connection can be described in DT too. > >> > >> Signed-off-by: Marek Vasut <marex@xxxxxxx> > >> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > >> Cc: Eric Anholt <eric@xxxxxxxxxx> > >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> > >> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > >> Cc: devicetree@xxxxxxxxxxxxxxx > >> --- > > > > Two general comments. > > - This driver should use the bridge panel - this will simplify the > > driver in many places. We already have several good examples in-tree > > that does this. > > Can you list such an example ? Take a look at tc358764.c in following patch-set: https://lore.kernel.org/dri-devel/20200726203324.3722593-1-sam@xxxxxxxxxxxx/ Your current driver will be even smaller after implmenting these changes. Sam
