On 4 June 2014 10:48, Peter Griffin <peter.griffin@xxxxxxxxxx> wrote: > Hi Ulf, > > Thanks for reviewing, see my comments below: - > > On Fri, 23 May 2014, Ulf Hansson wrote: >> > +static unsigned int sdhci_st_get_max_clk(struct sdhci_host *host) >> > +{ >> > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >> > + >> > + return clk_get_rate(pltfm_host->clk); >> > +} >> >> There are sdhci library function for the above: >> sdhci_pltfm_clk_get_max_clock() > > I've fixed in v2 to use the library function > >> > + host->mmc->caps |= MMC_CAP_8_BIT_DATA | MMC_CAP_BUS_WIDTH_TEST >> > + | MMC_CAP_1_8V_DDR; >> >> Comment below. >> >> > + >> > + if (of_property_read_bool(np, "non-removable")) >> > + host->mmc->caps |= MMC_CAP_NONREMOVABLE; >> >> MMC_CAP_1_8V_DDR, MMC_CAP_8_BIT_DATA, MMC_CAP_NONREMOVABLE aren’t >> those board specific capabilities? > > Yep >> >> Unless there are something that prevents you from using the common mmc >> DT parser, I would suggest you to use it. mmc_of_parse(). Thus you can >> provide these capabilities through DT instead. > > Thanks for pointing that out, I've switched over to using mmc_of_parse, > and everything works as expected. > > Also as an added bonus this will simplify support for the next SoC which > needs access to the high speed ddr / sdr bindings which > mmc_of_parse already supports :-) > > In v2 I've also removed the reset controller code from this platform driver > with the intention of adding it back in, in the generic code. The idea > would be that an additional 'reset' binding could be provided, which if > present would be used to deassert the IP reset line of the controller at > probe / resume, and assert reset at remove / sleep. > > Is this something you view as useful, if so I will prepare some RFC patches? Sounds useful. Please go ahead and send patches! :-) Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html