> On 21 Jul 2020, at 12:19 pm, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> On 21/07/2020 10:10, Neil Armstrong wrote:
>> On 19/07/2020 16:10, Christian Hewitt wrote:
>>> HardKernel ODROID-N2+ uses an Amlogic S922X rev. C chip capable of higher
>>> clock speeds than the original ODROID-N2. Hardkernel supports the big cpu
>>> cluster at 2.4GHz and the little cpu cluster at 2.0GHz. Opp points and
>>> regulator changess are from the HardKernel Linux kernel sources.
>>>
>>> Suggested-by: Dongjin Kim <tobetter@xxxxxxxxxxxxxx>
>>> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
>>> ---
>>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>>> .../dts/amlogic/meson-g12b-odroid-n2-plus.dts | 53 +++++++++++++++++++
>>> 2 files changed, 54 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>>> index 5cac4d1d487d..6dc508b80133 100644
>>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-gtking-pro.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
>>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>>> new file mode 100644
>>> index 000000000000..99e96be509f8
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
>>> @@ -0,0 +1,53 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright (c) 2019 BayLibre, SAS
>>> + * Author: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "meson-g12b-odroid-n2.dtsi"
>>> +
>>> +/ {
>>> + compatible = "hardkernel,odroid-n2-plus", "amlogic,s922x", "amlogic,g12b";
>>> + model = "Hardkernel ODROID-N2+";
>>> +
>>> + vddcpu_a: regulator-vddcpu-a {
>>> + regulator-min-microvolt = <680000>;
>>> + regulator-max-microvolt = <1040000>;
>>> +
>>> + pwms = <&pwm_ab 0 1500 0>;
>>> + };
>>> +
>>> + vddcpu_b: regulator-vddcpu-b {
>>> + regulator-min-microvolt = <680000>;
>>> + regulator-max-microvolt = <1040000>;
>>> +
>>> + pwms = <&pwm_AO_cd 1 1500 0>;
>>> + };
>>> +
>>> + cpu_opp_table_0: opp-table-0 {
>>> + opp-1908000000 {
>>> + opp-hz = /bits/ 64 <1908000000>;
>>> + opp-microvolt = <1030000>;
>>> + };
>>> +
>>> + opp-2016000000 {
>>> + opp-hz = /bits/ 64 <2016000000>;
>>> + opp-microvolt = <1040000>;
>>> + };
>>> + };
>>> +
>>> + cpub_opp_table_1: opp-table-1 {
>>> + opp-2304000000 {
>>> + opp-hz = /bits/ 64 <2304000000>;
>>> + opp-microvolt = <1030000>;
>>> + };
>>> +
>>> + opp-2400000000 {
>>> + opp-hz = /bits/ 64 <2400000000>;
>>> + opp-microvolt = <1040000>;
>>> + };
>>> + };
>>> +};
>>> +
>>>
>> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>>
>
> Wait no, it should be:
>
> / {
> compatible = "hardkernel,odroid-n2-plus", "amlogic,s922x", "amlogic,g12b";
> model = "Hardkernel ODROID-N2+";
> };
>
> &vddcpu_a {
> regulator-min-microvolt = <680000>;
> regulator-max-microvolt = <1040000>;
>
> pwms = <&pwm_ab 0 1500 0>;
> };
>
> &vddcpu_b {
> regulator-min-microvolt = <680000>;
> regulator-max-microvolt = <1040000>;
>
> pwms = <&pwm_AO_cd 1 1500 0>;
> };
>
> &cpu_opp_table_0 {
> opp-1908000000 {
> opp-hz = /bits/ 64 <1908000000>;
> opp-microvolt = <1030000>;
> };
>
> opp-2016000000 {
> opp-hz = /bits/ 64 <2016000000>;
> opp-microvolt = <1040000>;
> };
> };
>
> &cpub_opp_table_1 {
> opp-2304000000 {
> opp-hz = /bits/ 64 <2304000000>;
> opp-microvolt = <1030000>;
> };
>
> opp-2400000000 {
> opp-hz = /bits/ 64 <2400000000>;
> opp-microvolt = <1040000>;
> };
> };
>
> Neil
Okay, I will send corrected v2 and with model name changed.
Christian
