On Mon, Jul 20, 2020 at 12:16:33PM +0100, Jonathan Cameron wrote: > On Wed, 15 Jul 2020 14:58:21 +0530 > Nishant Malpani <nish.malpani25@xxxxxxxxx> wrote: > > > Add devicetree binding document for ADXRS290, a dual-axis MEMS gyroscope. > > > > Signed-off-by: Nishant Malpani <nish.malpani25@xxxxxxxxx> > > --- > > .../bindings/iio/gyroscope/adi,adxrs290.yaml | 52 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml > > new file mode 100644 > > index 000000000000..a997d945fdb0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright 2020 Analog Devices Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/gyroscope/adi,adxrs290.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices ADXRS290 Dual-Axis MEMS Gyroscope > > + > > +maintainers: > > + - Nishant Malpani <nish.malpani25@xxxxxxxxx> > > + > > +description: | > > + Bindings for the Analog Devices ADXRS290 dual-axis MEMS gyroscope device. > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ADXRS290.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - adi,adxrs290 > > I think we can use const here as only one item currently. Yep. Really depends if you expect to add more. > > > + > > + reg: > > + maxItems: 1 > > + > > + spi-max-frequency: > > + maximum: 5000000 > > + > > + spi-cpol: true > > + > > + spi-cpha: true > > + > > +required: > > + - compatible > > + - reg > > + - spi-max-frequency > > + - spi-cpol > > + - spi-cpha Add: additionalProperties: false > > + > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + gyro@0 { > > + compatible = "adi,adxrs290"; > > + reg = <0>; > > + spi-max-frequency = <5000000>; > > + spi-cpol; > > + spi-cpha; > > + }; > > + }; > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index dd02cfc410e8..0bb8ac90fba1 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1103,6 +1103,7 @@ M: Nishant Malpani <nish.malpani25@xxxxxxxxx> > > L: linux-iio@xxxxxxxxxxxxxxx > > S: Supported > > F: drivers/iio/gyro/adxrs290.c > > +F: Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml > > > > ANALOG DEVICES INC ASOC CODEC DRIVERS > > M: Lars-Peter Clausen <lars@xxxxxxxxxx> >