> -----Original Message----- > From: John Garry <john.garry@xxxxxxxxxx> > Sent: 2020年7月15日 19:04 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; will@xxxxxxxxxx; > mark.rutland@xxxxxxx; robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx > Cc: dl-linux-imx <linux-imx@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible > string > > On 12/05/2020 08:31, Joakim Zhang wrote: > > Update compatible string according to driver change.` > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > > --- > > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > index 7822a806ea0a..b27a1d4fec78 100644 > > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > @@ -4,7 +4,9 @@ Required properties: > > > > Hi Joakim, > > > - compatible: should be one of: > > "fsl,imx8-ddr-pmu" > > - "fsl,imx8m-ddr-pmu" > > + "fsl,imx8mq-ddr-pmu" > > + "fsl,imx8mm-ddr-pmu" > > I noticed that some of the compat strings being added are used in imx dtsi files > today: > > john@localhost:~/linux> git grep "fsl,imx8mm-ddr-pmu" > arch/arm64/boot/dts/freescale/imx8mm.dtsi: compatible = > "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; > > Any specific reason why they are not described in the dt bindings already? > > I don't follow dt so much anymore, so don't know the policies. Hi John, What I did is not standard, any compat string in dts file should be described in the dt bindings. I will keep in mind. Best Regards, Joakim Zhang > > + "fsl,imx8mn-ddr-pmu" > > Thanks, > John
