On 06/02/2014 02:18 PM, Marcel Ziswiler wrote: > On 06/02/2014 06:26 PM, Stephen Warren wrote: >>> + pwmleds { >>> + compatible = "pwm-leds"; >>> + >>> + pwm3 { >>> + label = "PWM3"; >>> + pwms = <&pwm 1 19600>; >>> + max-brightness = <255>; >>> + }; >>> + pwm2 { >>> + label = "PWM2"; >>> + pwms = <&pwm 2 19600>; >>> + max-brightness = <255>; >>> + }; >>> + pwm1 { >>> + label = "PWM1"; >>> + pwms = <&pwm 3 19600>; >>> + max-brightness = <255>; >>> + }; >> >> Nit: Why not sort those nodes in numerical order? > > Sure, the only question is ordering based on what. I choose the actual > Tegra PWM instance while you propose to use our Apalis instance > numbering which in this particular case turns out to be the opposite but > makes us even more happy to comply. Sorting by reg value, or if there is no reg value then alphanumerically, is what I've tried to (remember to) require for the Tegra DTs. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html