On Wed, Jul 15, 2020 at 8:04 PM 赵仪峰 <yifeng.zhao@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > >On Wed, 15 Jul 2020 17:03:39 +0800, Yifeng Zhao wrote: > >> Documentation support for Rockchip RK3xxx NAND flash controllers > >> > >> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx> > >> --- > >> > >> Changes in v7: > >> - Fix some wrong define > >> > >> Changes in v6: > >> - Fix some wrong define > >> - Modified the definition of compatible > >> > >> Changes in v5: > >> - Fix some wrong define. > >> - Add boot-medium define. > >> - Remove some compatible define. > >> > >> Changes in v4: > >> - The compatible define with rkxx_nfc. > >> - Add assigned-clocks. > >> - Fix some wrong defineChanges in. > >> > >> Changes in v3: > >> - Change the title for the dt-bindings. > >> > >> Changes in v2: None > >> > >> .../mtd/rockchip,nand-controller.yaml | 162 ++++++++++++++++++ > >> 1 file changed, 162 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > >> > > > > > >My bot found errors running 'make dt_binding_check' on your patch: > > > >/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml: example-0: nand-controller@ff4b0000:reg:0: [0, 4283105280, 0, 16384] is too long > > > > > >See https://patchwork.ozlabs.org/patch/1329325 > > > >If you already ran 'make dt_binding_check' and didn't see the above > >error(s), then make sure dt-schema is up to date: > > > >pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > >Please check and re-submit. > > make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTCC scripts/dtc/yamltree.o > HOSTLD scripts/dtc/dtc > CHKDT Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml > DTC Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml > CHECK Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml > /home/yifeng/work/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml: example-0: nand-controller@ff4b0000:reg:0: [0, 4283105280, 0, 16384] is too long > > I already ran the "make dt_binding_check" before submit this patch and found this issue. > The dts examples is for RK3308, ARCH=arm64, and the reg define is correct. > I thought there was something wrong with the check， or something configuration I missed. > Please give me some suggestions. > > > diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > index 493705a55638..b9d7a8c79402 100644 > --- a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > @@ -132,7 +132,7 @@ examples: > nfc: nand-controller@ff4b0000 { > compatible = "rockchip,rk3308-nfc", > "rockchip,rv1108-nfc"; > - reg = <0x0 0xff4b0000 0x0 0x4000>; > + reg = <0xff4b0000 0x4000>; This is the right fix. Or you can define a parent node with cell sizes of 2. The example is just an example and doesn't have to match exactly what you do in the dts files. > interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cru HCLK_NANDC>, <&cru SCLK_NANDC>; > clock-names = "ahb", "nfc";
