Hi bhanu, Thank you for your patch. This patch has some style problems, please make sure to fix and resent the patch. On 15/7/20 10:25, Bhanu Prakash Maiya wrote: > From: Bhanu Prakash Maiya <bhanumaiya@xxxxxxxxxxxx> > > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt > That's actually removed you should base your changes on top of https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=46b5780688c0d825b6b8d49b267b13102bea512d > Series-to: LKML <linux-kernel@xxxxxxxxxxxxxxx> > Series-cc: Raul E Rangel <rrangel@xxxxxxxxxxxx>, Furquan Shaikh <furquan@xxxxxxxxxxxx>, Duncan Laurie <dlaurie@xxxxxxxxxx>, Eric Peers <epeers@xxxxxxxxxx>, Benson Leung <bleung@xxxxxxxxxxxx>, Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>, Guenter Roeck <groeck@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Lee Jones <lee.jones@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx > I think you need to fix your patman workflow. This should be removed from here. > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@xxxxxxxxxxxx> > Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822 The Change-Id is useless upstream, please remove it. > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@xxxxxxxxxx> Only one signed-off per person please. > --- > Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt > index 4860eabd0f729..ec8c5d7ecc266 100644 > --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt > +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt > @@ -3,7 +3,7 @@ ChromeOS Embedded Controller > Google's ChromeOS EC is a Cortex-M device which talks to the AP and > implements various function such as keyboard and battery charging. > > -The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the > +The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the > compatible string used depends on the interface. Each connection method has > its own driver which connects to the top level interface-agnostic EC driver. > Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to > @@ -17,6 +17,10 @@ Required properties (SPI): > - compatible: "google,cros-ec-spi" > - reg: SPI chip select > > +Required properties (UART): > +- compatible: "google,cros-ec-uart" > +- reg: UART baudrate, flowcontrol > + That's odd, a reg that is mean to contain the baudrate and the flowcontrol? How? > Required properties (RPMSG): > - compatible: "google,cros-ec-rpmsg" > > @@ -72,5 +76,6 @@ spi@131b0000 { > }; > }; > > - > Example for LPC is not supplied as it is not yet implemented. > + > +Example for UART is not supplied as it is not yet implemented. >
